Skip to content

Make sure WeightedRandomizedLoadBalancer can traverse the whole server list#2953

Merged
wwbmmm merged 2 commits into
apache:masterfrom
chenBright:opt_wr
May 8, 2025
Merged

Make sure WeightedRandomizedLoadBalancer can traverse the whole server list#2953
wwbmmm merged 2 commits into
apache:masterfrom
chenBright:opt_wr

Conversation

@chenBright

@chenBright chenBright commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

In n tries, some servers with small weights may not be selected.

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm

wwbmmm commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

Maybe this need a rebase to fix the CI failure.

@chenBright

chenBright commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

Maybe this need a rebase to fix the CI failure.

@wwbmmm Done.

@wwbmmm

wwbmmm commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

LGTM

@chenBright

Copy link
Copy Markdown
Contributor Author

@wwbmmm Take a look if you have time.

Fix the problem of not traversing ExcludedServers.

@wwbmmm wwbmmm merged commit 011dabe into apache:master May 8, 2025
@chenBright chenBright deleted the opt_wr branch May 8, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants